Re: [PATCH v8 0/9] connect: various cleanups

2016-05-28 Thread Mike Hommey
On Sat, May 28, 2016 at 10:17:19AM +0200, Torsten Bögershausen wrote: > On 28.05.16 07:33, Mike Hommey wrote: > > On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote: > >> On 27.05.16 23:59, Mike Hommey wrote: > >>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen

Re: [PATCH v8 0/9] connect: various cleanups

2016-05-28 Thread Torsten Bögershausen
On 28.05.16 07:33, Mike Hommey wrote: > On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote: >> On 27.05.16 23:59, Mike Hommey wrote: >>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote: On 27.05.16 04:27, Mike Hommey wrote: > Changes from v7: > -

Re: [PATCH v8 0/9] connect: various cleanups

2016-05-27 Thread Mike Hommey
On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote: > On 27.05.16 23:59, Mike Hommey wrote: > > On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote: > >> On 27.05.16 04:27, Mike Hommey wrote: > >>> Changes from v7: > >>> - Fixed comments. > >>> > >>> Mike Hommey

Re: [PATCH v8 0/9] connect: various cleanups

2016-05-27 Thread Torsten Bögershausen
On 27.05.16 23:59, Mike Hommey wrote: > On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote: >> On 27.05.16 04:27, Mike Hommey wrote: >>> Changes from v7: >>> - Fixed comments. >>> >>> Mike Hommey (9): All in all, a great improvement. 2 things left. - The comment about [] is now

Re: [PATCH v8 0/9] connect: various cleanups

2016-05-27 Thread Mike Hommey
On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote: > On 27.05.16 04:27, Mike Hommey wrote: > > Changes from v7: > > - Fixed comments. > > > > Mike Hommey (9): > > connect: document why we sometimes call get_port after > > get_host_and_port > > connect: call

Re: [PATCH v8 0/9] connect: various cleanups

2016-05-27 Thread Torsten Bögershausen
On 27.05.16 04:27, Mike Hommey wrote: > Changes from v7: > - Fixed comments. > > Mike Hommey (9): > connect: document why we sometimes call get_port after > get_host_and_port > connect: call get_host_and_port() earlier > connect: re-derive a host:port string from the separate host and

[PATCH v8 0/9] connect: various cleanups

2016-05-26 Thread Mike Hommey
Changes from v7: - Fixed comments. Mike Hommey (9): connect: document why we sometimes call get_port after get_host_and_port connect: call get_host_and_port() earlier connect: re-derive a host:port string from the separate host and port variables connect: make parse_connect_url()