Re: [PATCH v8 00/15] nd/pack-objects-pack-struct updates

2018-04-06 Thread Jeff King
On Sat, Mar 31, 2018 at 12:02:56PM +0200, Nguyễn Thái Ngọc Duy wrote: > v8 changes > > - prefer BUG() over die() > - do "1U <<" instead of "1 << " to avoid undefined behavior with > signed shifting. > - add more comments based on Jeff's feedback > - plug a leak in try_delta() when delta_size is

Re: [PATCH v8 00/15] nd/pack-objects-pack-struct updates

2018-03-31 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 31 2018, Duy Nguyen wrote: > On Sat, Mar 31, 2018 at 1:36 PM, Ævar Arnfjörð Bjarmason > wrote: >>> +GIT_TEST_SPLIT_INDEX forces split-index mode on the whole test suite. >>> + >>> GIT_TEST_FULL_IN_PACK_ARRAY exercises the uncommon pack-objects code >>> path where there are more tha

Re: [PATCH v8 00/15] nd/pack-objects-pack-struct updates

2018-03-31 Thread Duy Nguyen
On Sat, Mar 31, 2018 at 1:36 PM, Ævar Arnfjörð Bjarmason wrote: >> +GIT_TEST_SPLIT_INDEX forces split-index mode on the whole test suite. >> + >> GIT_TEST_FULL_IN_PACK_ARRAY exercises the uncommon pack-objects code >> path where there are more than 1024 packs even if the actual number of >> pac

Re: [PATCH v8 00/15] nd/pack-objects-pack-struct updates

2018-03-31 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 31 2018, Nguyễn Thái Ngọc Duy wrote: I'm testing this and it looks good to me so far, aside from this: > - use git_env_*() instead of manually handling getenv() values > [...] > struct packed_git **mapping, *p; > - int cnt = 0, nr = 1 << OE_IN_PACK_BITS; > - > - if (get

[PATCH v8 00/15] nd/pack-objects-pack-struct updates

2018-03-31 Thread Nguyễn Thái Ngọc Duy
v8 changes - prefer BUG() over die() - do "1U <<" instead of "1 << " to avoid undefined behavior with signed shifting. - add more comments based on Jeff's feedback - plug a leak in try_delta() when delta_size is too large - be kind and set depth/cache_max_small_delta_size to max limit instead