On Fri, Dec 9, 2016 at 5:28 AM, Junio C Hamano wrote:
> Thanks.
>
> Will replace, with the attached stylistic fixes squashed in for
> minor issues that were spotted by my mechanical pre-acceptance
> filter.
>
Thanks for this. Will add it to my local branch too if there's a need
for a re-roll.
On Thu, Dec 8, 2016 at 5:31 AM, Jacob Keller wrote:
>> diff --git a/Documentation/git-for-each-ref.txt
>> b/Documentation/git-for-each-ref.txt
>> index f4ad297..c72baeb 100644
>> --- a/Documentation/git-for-each-ref.txt
>> +++ b/Documentation/git-for-each-ref.txt
>> @@ -92,13 +92,14 @@ refname::
On Thu, Dec 8, 2016 at 10:58 AM, Junio C Hamano wrote:
>
> *1* A malformed formatting request (e.g. %(if) that is not closed)
> cannot be satisified but that is true for all refs and is
> outside of the scope of this discussion. The command should die
> and I think it already does.
A
Thanks.
Will replace, with the attached stylistic fixes squashed in for
minor issues that were spotted by my mechanical pre-acceptance
filter.
ref-filter.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git b/ref-filter.c a/ref-filter.c
index a68ed7b147..a9d2c6a89d 10
Jacob Keller writes:
>> + are left behind. If a displayed ref has fewer components than
>> + ``, the command aborts with an error.
>>
>
> Would it make more sense to not die and instead just return the empty
> string? On the one hand, if we die() it's obvious that you tried to
> stri
On Wed, Dec 7, 2016 at 7:36 AM, Karthik Nayak wrote:
> This is part of unification of the commands 'git tag -l, git branch -l
> and git for-each-ref'. This ports over branch.c to use ref-filter's
> printing options.
>
> Initially posted here: $(gmane/279226). It was decided that this series
> woul
This is part of unification of the commands 'git tag -l, git branch -l
and git for-each-ref'. This ports over branch.c to use ref-filter's
printing options.
Initially posted here: $(gmane/279226). It was decided that this series
would follow up after refactoring ref-filter parsing mechanism, which
7 matches
Mail list logo
