On Thu, May 22, 2014 at 4:08 PM, Jonathan Nieder wrote:
> Ronnie Sahlberg wrote:
>
>> This patch series can also be found at
>> https://github.com/rsahlberg/git/tree/ref-transactions
>
> Continuing with the review of 65a1cb7b (2014-05-22 12:08):
>
> 11/40 change ref_transaction_update() to do err
Ronnie Sahlberg wrote:
> This patch series can also be found at
> https://github.com/rsahlberg/git/tree/ref-transactions
Continuing with the review of 65a1cb7b (2014-05-22 12:08):
11/40 change ref_transaction_update() to do error checking and return status
The "there will be in the future" sou
Ronnie Sahlberg wrote:
> This patch series can also be found at
> https://github.com/rsahlberg/git/tree/ref-transactions
Thoughts on 65a1cb7b (2014-05-22 12:08):
04/40 add a strbuf argument to ref_transaction_commit for error logging
Ideally this would come after the functions it calls so the
Ronnie Sahlberg wrote:
> This patch series can also be found at
> https://github.com/rsahlberg/git/tree/ref-transactions
Thoughts on 65a1cb7b (2014-05-22 12:08):
01/40 remove ref_transaction_rollback
Reviewed-by: Jonathan Nieder
02/40 constify the sha arguments for ref_transaction_create|de
Ronnie Sahlberg wrote:
> This version completes the work to convert all ref updates to use
> transactions.
Finally got through this. It had thorny bits but generally goes in a
very good direction. Thanks for a pleasant read.
Feel free to send another iteration if you'd like review for the new
Jonathan Nieder writes:
> Ronnie Sahlberg wrote:
>
>> This patch series is based on next and expands on the transaction API.
>
> Thanks. Will pick up in v8 where I left off with v6.
>
> Applies with just one minor conflict on top of a merge of
> mh/ref-transaction, rs/ref-update-check-errors-ear
Ronnie Sahlberg wrote:
> This patch series is based on next and expands on the transaction API.
Thanks. Will pick up in v8 where I left off with v6.
Applies with just one minor conflict on top of a merge of
mh/ref-transaction, rs/ref-update-check-errors-early, and
rs/reflog-exists. Here's an i
This patch series can also be found at
https://github.com/rsahlberg/git/tree/ref-transactions
This patch series is based on next and expands on the transaction API. It
converts all ref updates, inside refs.c as well as external, to use the
transaction API for updates. This makes most of the ref u
8 matches
Mail list logo