Re: [PATCH v8 04/11] update-index: add untracked cache notifications

2017-03-30 Thread Stefan Beller
On Thu, Mar 30, 2017 at 10:33 AM, Junio C Hamano wrote: >> >> Coverity points out that this is a leak (xgetcwd returns an allocated >> buffer). > > I saw that quite recently and was wondering why it reported it this > late. It has been in 'master' for more than a month. Because the repo/script f

Re: [PATCH v8 04/11] update-index: add untracked cache notifications

2017-03-30 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote: > >> diff --git a/builtin/update-index.c b/builtin/update-index.c >> index 6dd..369c207 100644 >> --- a/builtin/update-index.c >> +++ b/builtin/update-index.c >> @@ -130,7 +130,7 @@ static int test_if_untrac

Re: [PATCH v8 04/11] update-index: add untracked cache notifications

2017-03-29 Thread Christian Couder
On Thu, Mar 30, 2017 at 5:28 AM, Jeff King wrote: > On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote: > >> diff --git a/builtin/update-index.c b/builtin/update-index.c >> index 6dd..369c207 100644 >> --- a/builtin/update-index.c >> +++ b/builtin/update-index.c >> @@ -130,7 +130

Re: [PATCH v8 04/11] update-index: add untracked cache notifications

2017-03-29 Thread Jeff King
On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote: > diff --git a/builtin/update-index.c b/builtin/update-index.c > index 6dd..369c207 100644 > --- a/builtin/update-index.c > +++ b/builtin/update-index.c > @@ -130,7 +130,7 @@ static int test_if_untracked_cache_is_supported(void)

[PATCH v8 04/11] update-index: add untracked cache notifications

2016-01-26 Thread Christian Couder
Attempting to flip the untracked-cache feature on for a random index file with cd /random/unrelated/place git --git-dir=/somewhere/else/.git update-index --untracked-cache would not work as you might expect. Because flipping the feature on in the index also records the location of the cor