Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-23 Thread Junio C Hamano
Pranit Bauva writes: > On Thu, Mar 24, 2016 at 12:49 AM, Junio C Hamano wrote: >> Pranit Bauva writes: >> >>> On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine >>> wrote: >>> ... Alternatively, combine #1 and #2 into a single patch which drops the global test_set_editor() and, as an a

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-23 Thread Pranit Bauva
On Thu, Mar 24, 2016 at 12:49 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine >> wrote: >> ... >>> Alternatively, combine #1 and #2 into a single patch which drops the >>> global test_set_editor() and, as an aside, also does "while here, >>>

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-23 Thread Junio C Hamano
Pranit Bauva writes: > On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine > wrote: > ... >> Alternatively, combine #1 and #2 into a single patch which drops the >> global test_set_editor() and, as an aside, also does "while here, >> let's use write_script() to create 'check-for'diff' rather than d

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-20 Thread Pranit Bauva
On Sun, Mar 20, 2016 at 11:04 PM, Eric Sunshine wrote: > On Sun, Mar 20, 2016 at 7:05 AM, Pranit Bauva wrote: >> On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine >> wrote: >>> However, more intuitive would probably be to create another "editor" >>> similar to the 'check-for-diff' editor this scri

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-20 Thread Eric Sunshine
On Sun, Mar 20, 2016 at 7:05 AM, Pranit Bauva wrote: > On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine > wrote: >> However, more intuitive would probably be to create another "editor" >> similar to the 'check-for-diff' editor this script already uses. (The >> 'check-for-diff' editor is an obvious

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-20 Thread Pranit Bauva
On Sun, Mar 20, 2016 at 9:26 AM, Eric Sunshine wrote: > On Fri, Mar 18, 2016 at 5:19 PM, Pranit Bauva wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. >> >> Signed-off-by: Pranit Bauva >> --- >> diff --git a/builtin/commit.c b/builtin

Re: [PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-19 Thread Eric Sunshine
On Fri, Mar 18, 2016 at 5:19 PM, Pranit Bauva wrote: > Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Signed-off-by: Pranit Bauva > --- > diff --git a/builtin/commit.c b/builtin/commit.c > @@ -1654,6 +1661,14 @@ int cmd_commit(int argc, con

[PATCH v8 2/2] commit: add a commit.verbose config variable

2016-03-19 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous version of the patch are: - [v7] $gmane/288820 - [v6] $gmane/288728 - [v5] $gmane/288728 - [v4]