Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction

2014-05-19 Thread Ronnie Sahlberg
On Fri, May 16, 2014 at 3:54 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: --- a/builtin/fetch.c +++ b/builtin/fetch.c [...] @@ -384,15 +384,16 @@ static int s_update_ref(const char *action, snprintf(msg, sizeof(msg), %s: %s, rla, action); errno = 0; -

Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction

2014-05-16 Thread Jonathan Nieder
(+cc: peff for STORE_REF_ERROR_DF_CONFLICT expertise) Ronnie Sahlberg wrote: --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -375,7 +375,7 @@ static int s_update_ref(const char *action, [...] + transaction = ref_transaction_begin(); + if (!transaction || +

Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction

2014-05-16 Thread Ronnie Sahlberg
On Fri, May 16, 2014 at 12:12 PM, Jonathan Nieder jrnie...@gmail.com wrote: (+cc: peff for STORE_REF_ERROR_DF_CONFLICT expertise) Ronnie Sahlberg wrote: --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -375,7 +375,7 @@ static int s_update_ref(const char *action, [...] + transaction =

Re: [PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction

2014-05-16 Thread Jonathan Nieder
Ronnie Sahlberg wrote: --- a/builtin/fetch.c +++ b/builtin/fetch.c [...] @@ -384,15 +384,16 @@ static int s_update_ref(const char *action, snprintf(msg, sizeof(msg), %s: %s, rla, action); errno = 0; - lock = lock_any_ref_for_update(ref-name, -

[PATCH v8 23/44] fetch.c: change s_update_ref to use a ref transaction

2014-05-15 Thread Ronnie Sahlberg
Change s_update_ref to use a ref transaction for the ref update. Signed-off-by: Ronnie Sahlberg sahlb...@google.com --- builtin/fetch.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/builtin/fetch.c b/builtin/fetch.c index a93c893..b41d7b7 100644 ---