Re: [PATCH v8 36/41] apply: don't print on stdout when be_silent is set

2016-07-26 Thread Junio C Hamano
Christian Couder writes: > This variable should prevent anything to be printed on both stderr > and stdout. You have to mention that skipping the entire callchain, not just the "printing" part, is safe. I can see numstat_patch_list() is probably safe as it does not do any computation other than

[PATCH v8 36/41] apply: don't print on stdout when be_silent is set

2016-06-27 Thread Christian Couder
This variable should prevent anything to be printed on both stderr and stdout. Signed-off-by: Christian Couder --- apply.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apply.c b/apply.c index 1435f85..e2acc18 100644 --- a/apply.c +++ b/apply.c @@ -4698,13 +4698,13 @@