Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref

2014-05-22 Thread Ronnie Sahlberg
On Wed, May 21, 2014 at 4:57 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: This means that most loose refs will no longer be present after the rename Is this to handle the git branch -m foo/bar foo case or for some other purpose? Yes. That is the main reason. [...]

Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref

2014-05-22 Thread Ronnie Sahlberg
On Thu, May 22, 2014 at 10:51 AM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: On Wed, May 21, 2014 at 4:57 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: This means that most loose refs will no longer be present after the rename Is this to handle

Re: [PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref

2014-05-21 Thread Jonathan Nieder
Ronnie Sahlberg wrote: This means that most loose refs will no longer be present after the rename Is this to handle the git branch -m foo/bar foo case or for some other purpose? [...] --- a/t/t3200-branch.sh +++ b/t/t3200-branch.sh @@ -289,7 +289,7 @@ test_expect_success 'renaming a symref

[PATCH v8 38/44] refs.c: pack all refs before we start to rename a ref

2014-05-15 Thread Ronnie Sahlberg
This means that most loose refs will no longer be present after the rename which triggered a test failure since it assumes the file for an unrelated ref would still be present after the rename. Signed-off-by: Ronnie Sahlberg sahlb...@google.com --- refs.c| 3 +++ t/t3200-branch.sh |