[PATCH v9 4/5] http: create function to get curl allowed protocols

2016-12-13 Thread Brandon Williams
Move the creation of an allowed protocols whitelist to a helper function. Signed-off-by: Brandon Williams --- http.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/http.c b/http.c index 034426e..f7c488a 100644 --- a/http.c +++ b/http.c @@ -4

Re: [PATCH v9 4/5] http: create function to get curl allowed protocols

2016-12-14 Thread Jeff King
On Tue, Dec 13, 2016 at 05:40:36PM -0800, Brandon Williams wrote: > Move the creation of an allowed protocols whitelist to a helper > function. This is "what" but not "why". You can figure it out if you see the next patch, but it's often nice to make a brief mention, like: This will be useful

Re: [PATCH v9 4/5] http: create function to get curl allowed protocols

2016-12-14 Thread Brandon Williams
On 12/14, Jeff King wrote: > On Tue, Dec 13, 2016 at 05:40:36PM -0800, Brandon Williams wrote: > > > Move the creation of an allowed protocols whitelist to a helper > > function. > > This is "what" but not "why". You can figure it out if you see the next > patch, but it's often nice to make a bri