Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@imag.fr writes: + +git bisect terms term-new term-old + The mnemonic for git bisect start bad good is Bad comes before Good (B

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: The second sentence may want to be something like If you mistyped one of the terms, you can do another git bisect terms term-new term-old to correct them, but that is possible only before you start the bisection. Applied, thanks. I

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: This is currently how it's implemented. You need to say $ git bisect terms foo bar $ git bisect start Ahh, it means everything including the description (i.e. you start bisection) is consistent and perfectly fine. I misread the patch, it

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: And worse yet, majority of users may read git bisect start is where you start bisection, but bisect start (either called directly, or via bisect_autostart by the first git bisect good) is where you set up the machinery, so doing bisect terms before

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-26 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: The second sentence may want to be something like If you mistyped one of the terms, you can do another git bisect terms term-new term-old to correct them, but that is possible only

[PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Matthieu Moy
From: Antoine Delaite antoine.dela...@ensimag.grenoble-inp.fr Introduction of the git bisect terms command. The user can set his own terms. It will work exactly like before. The terms must be set before the start. Signed-off-by: Antoine Delaite antoine.dela...@ensimag.grenoble-inp.fr

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: +Only the first bisection following the `git bisect terms` will use the +terms. If you mistyped one of the terms you can do again `git bisect +terms term-old term-new`. This paragraph may need further polishing. The first sentence makes it sound as if

Re: [PATCH v9 5/5] bisect: allow any terms set by user

2015-06-25 Thread Junio C Hamano
Matthieu Moy matthieu@imag.fr writes: + +git bisect terms term-new term-old + The mnemonic for git bisect start bad good is Bad comes before Good (B = 0x42, G = 0x47) and this is same for