Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Junio C Hamano
Luke Diamand writes: >> What I am trying to get at is if we want to use a single command >> that can be given a path and answer "Yes, that is a repository" >> here, and that single command should know how the repository should >> look like. I offhand do not know we already

Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Luke Diamand
On 5 December 2016 at 21:24, Junio C Hamano wrote: > Luke Diamand writes: > >> On 5 December 2016 at 20:53, Junio C Hamano wrote: >>> Luke Diamand writes: >>> Teach git-p4 about git-workspaces. >>> >>> Is this what

Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Junio C Hamano
Junio C Hamano writes: > Luke Diamand writes: > ... > if (os.path.exists(path + "/HEAD") > and os.path.exists(path + "/refs") and os.path.exists(path + > "/objects")): > return True; > + > +# secondary working tree managed by "git

Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Luke Diamand
On 5 December 2016 at 20:53, Junio C Hamano wrote: > Luke Diamand writes: > >> Teach git-p4 about git-workspaces. > > Is this what we call "git worktree", or something else? Ah, I think you're right! > >> >> Signed-off-by: Luke Diamand >>

Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Junio C Hamano
Luke Diamand writes: > On 5 December 2016 at 20:53, Junio C Hamano wrote: >> Luke Diamand writes: >> >>> Teach git-p4 about git-workspaces. >> >> Is this what we call "git worktree", or something else? > > Ah, I think you're right! Then

Re: [PATCHv1 1/2] git-p4: support git-workspaces

2016-12-05 Thread Junio C Hamano
Luke Diamand writes: > Teach git-p4 about git-workspaces. Is this what we call "git worktree", or something else? > > Signed-off-by: Luke Diamand > --- > git-p4.py | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/git-p4.py b/git-p4.py > index

[PATCHv1 1/2] git-p4: support git-workspaces

2016-12-02 Thread Luke Diamand
Teach git-p4 about git-workspaces. Signed-off-by: Luke Diamand --- git-p4.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/git-p4.py b/git-p4.py index 0c4f2afd2..5e2db1919 100755 --- a/git-p4.py +++ b/git-p4.py @@ -566,6 +566,12 @@ def isValidGitDir(path): if