Re: [PATCHv14 0/7] Expose submodule parallelism to the user

2016-02-23 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Feb 23, 2016 at 3:33 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> Looks good. I didn't notice these unnecessary blank lines while >>> reading the previous rounds, and it is good to see them

Re: [PATCHv14 0/7] Expose submodule parallelism to the user

2016-02-23 Thread Stefan Beller
On Tue, Feb 23, 2016 at 3:33 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Looks good. I didn't notice these unnecessary blank lines while >> reading the previous rounds, and it is good to see them go. >> >> Let's wait for a few days and merge

Re: [PATCHv14 0/7] Expose submodule parallelism to the user

2016-02-23 Thread Junio C Hamano
Junio C Hamano writes: > Looks good. I didn't notice these unnecessary blank lines while > reading the previous rounds, and it is good to see them go. > > Let's wait for a few days and merge them to 'next'. David's ref > backend topic textually depends on this, and we'd

Re: [PATCHv14 0/7] Expose submodule parallelism to the user

2016-02-19 Thread Junio C Hamano
Looks good. I didn't notice these unnecessary blank lines while reading the previous rounds, and it is good to see them go. Let's wait for a few days and merge them to 'next'. David's ref backend topic textually depends on this, and we'd better give it a solid foundation to build on soon.

[PATCHv14 0/7] Expose submodule parallelism to the user

2016-02-19 Thread Stefan Beller
Thanks Junio, Jeff and Eric for reviewing once again! * fixes as proposed by Junio for readability in parse_submodule_update_strategy * Do not leak the `url`, as found by Jeff. (I dug into the code of argv_array_pushl and you're obviously correct) Thanks, Stefan Interdiff to v13: diff --git