Re: [PATCHv14 5/7] git submodule update: have a dedicated helper for cloning

Stefan Beller wrote: > On Fri, Feb 19, 2016 at 3:07 PM, Jonathan Nieder wrote: [...] >>> + strbuf_addf(err, "Skipping submodule '%s'\n", >>> + displaypath); >> >> Does the caller expect a newline at the end of err? >> >> In the refs code

Re: [PATCHv14 5/7] git submodule update: have a dedicated helper for cloning

On Fri, Feb 19, 2016 at 3:07 PM, Jonathan Nieder wrote: > > I still have trouble reading this patch (patch 5). Some musing below > to figure out what could change to make it more readable (perhaps in a > patch on top). After this review (I added replies from bottom to top,

Re: [PATCHv14 5/7] git submodule update: have a dedicated helper for cloning

Hi, Stefan Beller wrote: > This introduces a new helper function in git submodule--helper > which takes care of cloning all submodules, which we want to > parallelize eventually. Patches 1-4 are still Reviewed-by: Jonathan Nieder I still have trouble reading this patch

[PATCHv14 5/7] git submodule update: have a dedicated helper for cloning

This introduces a new helper function in git submodule--helper which takes care of cloning all submodules, which we want to parallelize eventually. Some tests (such as empty URL, update_mode=none) are required in the helper to make the decision for cloning. These checks have been moved into the C