Re: [PATCHv19 00/11] Expose submodule parallelism to the user

On Mon, Feb 29, 2016 at 1:51 PM, Junio C Hamano wrote: > Johannes Sixt writes: > >> Am 29.02.2016 um 22:19 schrieb Junio C Hamano: >>> Stefan Beller writes: >>> Maybe we want to remove the struct child_process from the function

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Johannes Sixt writes: > Am 29.02.2016 um 22:19 schrieb Junio C Hamano: >> Stefan Beller writes: >> >>> Maybe we want to remove the struct child_process from the >>> function signature of the callbacks and callbacks need to rely on >>> the data provided solely

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Am 29.02.2016 um 22:19 schrieb Junio C Hamano: Stefan Beller writes: Maybe we want to remove the struct child_process from the function signature of the callbacks and callbacks need to rely on the data provided solely thru the pointer as passed around for callback

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

On Mon, Feb 29, 2016 at 1:19 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Maybe we want to remove the struct child_process from the >> function signature of the callbacks and callbacks need to rely on >> the data provided solely thru the pointer

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Stefan Beller writes: > Maybe we want to remove the struct child_process from the > function signature of the callbacks and callbacks need to rely on > the data provided solely thru the pointer as passed around for > callback purposes, which the user is free to use for any

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

On Mon, Feb 29, 2016 at 1:01 PM, Junio C Hamano wrote: > Johannes Sixt writes: > >> The culprit seems to be default_task_finished(), which accesses argv[] >> of the struct child_process after finish_command has released it, >> provided the child exited with an

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Johannes Sixt writes: > The culprit seems to be default_task_finished(), which accesses argv[] > of the struct child_process after finish_command has released it, > provided the child exited with an error, for example: Thanks for a report. > ==3395== Invalid read of size 8 >

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

On Mon, Feb 29, 2016 at 12:48 PM, Johannes Sixt wrote: > Hi folks, > > we have a major breakage in the parallel tasks infrastructure, and I'm > afraid it is already in master. > > Instrument the code in sb/submodule-parallel-update like this and enjoy > the fireworks of

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Hi folks, we have a major breakage in the parallel tasks infrastructure, and I'm afraid it is already in master. Instrument the code in sb/submodule-parallel-update like this and enjoy the fireworks of './t7400-submodule-basic.sh -v -i -x --debug': diff --git a/git-submodule.sh

Re: [PATCHv19 00/11] Expose submodule parallelism to the user

Stefan Beller wrote: > Thanks Jonathan (and all the other cc'd reviewers) for bearing > yet another revision! Thanks. This one looks good. Reviewed-by: Jonathan Nieder -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

[PATCHv19 00/11] Expose submodule parallelism to the user

Thanks Jonathan (and all the other cc'd reviewers) for bearing yet another revision! I changed the prefix handling back again as it is more consistent. Once this series is landed, I plan to refactor the prefix handling for all the submodule--helper commands. Thanks, Stefan Interdiff to v18: