Re: [PATCHv2 0/2] (x)diff cleanup: remove duplicate code

2017-10-25 Thread Stefan Beller
On Tue, Oct 24, 2017 at 10:11 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> v2: >> * I realized that we don't have to change the hashing function of xdiff; >> we can rather change the hashing function for the move detection, >> which is less

Re: [PATCHv2 0/2] (x)diff cleanup: remove duplicate code

2017-10-24 Thread Junio C Hamano
Stefan Beller writes: > v2: > * I realized that we don't have to change the hashing function of xdiff; > we can rather change the hashing function for the move detection, > which is less fundamental. > (That way I can shrink the series down to 2 patches) > * commented

[PATCHv2 0/2] (x)diff cleanup: remove duplicate code

2017-10-24 Thread Stefan Beller
v2: * I realized that we don't have to change the hashing function of xdiff; we can rather change the hashing function for the move detection, which is less fundamental. (That way I can shrink the series down to 2 patches) * commented and renamed function parameters in the exposed xdiff