Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-05-01 Thread Junio C Hamano
Jeff King writes: > PS Outside of our test scripts, I'd probably just have written: > > perl -lpe 'print "extra line" if $. == 2' > >I think we have traditionally preferred sed/awk to perl, but given >the heavy use of vanilla perl elsewhere in the test suite, I think

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-30 Thread Jeff King
On Sun, Apr 30, 2017 at 06:11:48PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > diff --git a/t/t4051-diff-function-context.sh > > b/t/t4051-diff-function-context.sh > > index 6154acb45..5f46c0341 100755 > > --- a/t/t4051-diff-function-context.sh > > +++

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-30 Thread Junio C Hamano
Jeff King writes: > diff --git a/t/t4051-diff-function-context.sh > b/t/t4051-diff-function-context.sh > index 6154acb45..5f46c0341 100755 > --- a/t/t4051-diff-function-context.sh > +++ b/t/t4051-diff-function-context.sh > @@ -72,7 +72,7 @@ test_expect_success 'setup' ' > >

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-29 Thread Michael Haggerty
On 04/29/2017 02:40 PM, Jeff King wrote: > On Fri, Apr 28, 2017 at 06:33:12PM -0400, Marc Branchaud wrote: > >> v2: Fixed up the commit messages and added tests. >> >> Marc Branchaud (2): >> diff: make the indent heuristic part of diff's basic configuration >> diff: have the diff-* builtins

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-29 Thread Jeff King
On Sat, Apr 29, 2017 at 08:40:52AM -0400, Jeff King wrote: > On Fri, Apr 28, 2017 at 06:33:12PM -0400, Marc Branchaud wrote: > > > v2: Fixed up the commit messages and added tests. > > > > Marc Branchaud (2): > > diff: make the indent heuristic part of diff's basic configuration > > diff:

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-29 Thread Jeff King
On Fri, Apr 28, 2017 at 06:33:12PM -0400, Marc Branchaud wrote: > v2: Fixed up the commit messages and added tests. > > Marc Branchaud (2): > diff: make the indent heuristic part of diff's basic configuration > diff: have the diff-* builtins configure diff before initializing > revisions

[PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

2017-04-28 Thread Marc Branchaud
v2: Fixed up the commit messages and added tests. Marc Branchaud (2): diff: make the indent heuristic part of diff's basic configuration diff: have the diff-* builtins configure diff before initializing revisions Stefan Beller (1): diff: enable indent heuristic by default