On Wed, Mar 30, 2016 at 10:32:40AM -0700, Stefan Beller wrote:
> > I'm OK with all of these as-is, though I did mention a nit in the third
> > one. I also like Junio's rewrite instead of using strbuf_list_free.
>
> I'm fine using the rewritten version instead of using strbuf_list_free. :)
> On th
On Wed, Mar 30, 2016 at 10:25 AM, Jeff King wrote:
> On Wed, Mar 30, 2016 at 10:05:14AM -0700, Stefan Beller wrote:
>
>> v2:
>> Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here
>> is a v2.
>>
>> * drop the overallocation patches (1&2)
>> * use git_config_get_string instead o
On Wed, Mar 30, 2016 at 10:05:14AM -0700, Stefan Beller wrote:
> v2:
> Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here
> is a v2.
>
> * drop the overallocation patches (1&2)
> * use git_config_get_string instead of its _const equivalent, such that
> we don't need a cast
v2:
Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here
is a v2.
* drop the overallocation patches (1&2)
* use git_config_get_string instead of its _const equivalent, such that
we don't need a cast when freeing in git_config_get_notes_strategy
* Use strbuf_list_free instead o
4 matches
Mail list logo