Re: [PATCHv2 00/24] Bring more repository handles into our code base]

2018-11-01 Thread Junio C Hamano
Stefan Beller writes: >> What was posted would have been perfectly fine as a "how about doing >> it this way" weatherbaloon patch, but as a part of real series, it >> needs to explain to the developers what the distinctions between two >> classes are, and who is to use the cocci patch at what

Re: [PATCHv2 00/24] Bring more repository handles into our code base]

2018-11-01 Thread Stefan Beller
On Tue, Oct 30, 2018 at 11:41 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > I also picked up the patch for pending semantic patches, as the > > first patch, can I have your sign off, please? > > I find this step quite lacking. > > What was posted would have been perfectly fine as a

Re: [PATCHv2 00/24] Bring more repository handles into our code base]

2018-10-31 Thread Junio C Hamano
Stefan Beller writes: > I also picked up the patch for pending semantic patches, as the > first patch, can I have your sign off, please? I find this step quite lacking. What was posted would have been perfectly fine as a "how about doing it this way" weatherbaloon patch, but as a part of

[PATCHv2 00/24] Bring more repository handles into our code base]

2018-10-30 Thread Stefan Beller
This resends sb/more-repo-in-api On Thu, Oct 25, 2018 at 2:14 AM SZEDER Gábor wrote: > On Tue, Oct 16, 2018 at 04:35:49PM -0700, Stefan Beller wrote: > > This converts the 'show_submodule_header' function to use > > the repository API properly, such that the submodule objects > > are not added