Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine wrote: >> + else if (!me->overwrite && submodule->update != NULL) > > Although "foo != NULL" is unusual in this code-base, it is used > elsewhere in this file, including just outside the context seen above. >

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Fri, Oct 30, 2015 at 1:38 PM, Stefan Beller wrote: > On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine wrote: >>> + else if (!me->overwrite && submodule->update != NULL) >> >> Although "foo != NULL" is unusual in this code-base, it is

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Fri, Oct 30, 2015 at 11:16 AM, Eric Sunshine wrote: > On Fri, Oct 30, 2015 at 1:38 PM, Stefan Beller wrote: >> On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine >> wrote: + else if (!me->overwrite &&

Re: [PATCHv2 2/8] submodule config: keep update strategy around

On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller wrote: > We need the submodule update strategies in a later patch. > > Signed-off-by: Stefan Beller > Signed-off-by: Junio C Hamano > --- > diff --git a/submodule-config.c

[PATCHv2 2/8] submodule config: keep update strategy around

We need the submodule update strategies in a later patch. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- submodule-config.c | 11 +++ submodule-config.h | 1 + 2 files changed, 12 insertions(+) diff --git a/submodule-config.c