Re: [PATCHv2 4/8] ident: keep separate explicit flags for author and committer

2012-11-15 Thread Jonathan Nieder
Jeff King wrote: 1. GIT_COMMITTER_* is set explicitly, but we fallback for GIT_AUTHOR. We claim the ident is explicit, even though the author is not. 2. GIT_AUTHOR_* is set and we ask for author ident, but not committer ident. We will claim the ident is implicit,

[PATCHv2 4/8] ident: keep separate explicit flags for author and committer

2012-11-14 Thread Jeff King
We keep track of whether the user ident was given to us explicitly, or if we guessed at it from system parameters like username and hostname. However, we kept only a single variable. This covers the common cases (because the author and committer will usually come from the same explicit source),