Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Michael Haggerty
On 01/22/2015 03:32 AM, Stefan Beller wrote: By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. Signed-off-by: Stefan Beller sbel...@google.com --- refs.c| 17

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Ramsay Jones
On 22/01/15 02:32, Stefan Beller wrote: By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. Signed-off-by: Stefan Beller sbel...@google.com --- refs.c| 17

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Jeff King
On Thu, Jan 22, 2015 at 12:24:23PM +0100, Michael Haggerty wrote: I can't figure out where to apply this series or where to fetch it from, so I can't see these changes in context, so maybe I'm misunderstanding something. It looks like this code is doing open(), close(), open(),

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Michael Haggerty
On 01/22/2015 02:10 PM, Jeff King wrote: On Thu, Jan 22, 2015 at 12:24:23PM +0100, Michael Haggerty wrote: I can't figure out where to apply this series or where to fetch it from, so I can't see these changes in context, so maybe I'm misunderstanding something. It looks like this code is

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Stefan Beller
How do you run sparse on git? I noticed there is 'make sparse' though I cannot get it working here in the corporate world as I have problems with openssl headers not being found. Also the line numbers seem to bit off compared to what I have here, did you need to modify/preprocess files to get

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Ramsay Jones
On 22/01/15 19:16, Stefan Beller wrote: How do you run sparse on git? $ make sparse sp-out 21 I noticed there is 'make sparse' though I cannot get it working here in the corporate world as I have problems with openssl headers not being found. If you can build git with gcc, you should be

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Stefan Beller
On Thu, Jan 22, 2015 at 8:33 AM, Michael Haggerty mhag...@alum.mit.edu wrote: On 01/22/2015 02:10 PM, Jeff King wrote: On Thu, Jan 22, 2015 at 12:24:23PM +0100, Michael Haggerty wrote: I can't figure out where to apply this series or where to fetch it from, so I can't see these changes in

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Ramsay Jones
On 22/01/15 19:51, Ramsay Jones wrote: On 22/01/15 19:16, Stefan Beller wrote: How do you run sparse on git? $ make sparse sp-out 21 BTW, you can get gcc to warn about this also: $ rm refs.o $ make CFLAGS='-Wall -Wextra' refs.o * new build flags CC refs.o In file included from

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Stefan Beller
On Thu, Jan 22, 2015 at 12:13 PM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Notice the [-Wextra] warnings above. ;-) ATB, Ramsay Jones Thanks, I put that into my config.mak Though recompiling the whole project yields 4 [-Wempty-body] 477 [-Wmissing-field-initializers]

Re: [PATCHv2 5/5] refs.c: enable large transactions

2015-01-22 Thread Ramsay Jones
On 22/01/15 20:20, Stefan Beller wrote: On Thu, Jan 22, 2015 at 12:13 PM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: Notice the [-Wextra] warnings above. ;-) ATB, Ramsay Jones Thanks, I put that into my config.mak Though recompiling the whole project yields 4

[PATCHv2 5/5] refs.c: enable large transactions

2015-01-21 Thread Stefan Beller
By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. Signed-off-by: Stefan Beller sbel...@google.com --- refs.c| 17 + t/t1400-update-ref.sh | 4 ++-- 2 files