Re: [PATCHv3 3/5] t7406: prefer test_* helper functions to test -[feds]

2018-08-07 Thread Junio C Hamano
Elijah Newren writes: > test -e, test -s, etc. do not provide nice error messages when we hit > test failures, so use the test_* helper functions from > test-lib-functions.sh. Good explanation. > Note: The use of 'test_path_is_file submodule/.git' may look odd, but > it is a file which is

[PATCHv3 3/5] t7406: prefer test_* helper functions to test -[feds]

2018-08-07 Thread Elijah Newren
test -e, test -s, etc. do not provide nice error messages when we hit test failures, so use the test_* helper functions from test-lib-functions.sh. Note: The use of 'test_path_is_file submodule/.git' may look odd, but it is a file which is populated with a gitdir: ../.git/modules/submodule