Re: [PATCHv3 6/6] refs.c: enable large transactions

2015-01-26 Thread Stefan Beller
On Fri, Jan 23, 2015 at 4:38 PM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: On Fri, Jan 23, 2015 at 4:14 PM, Junio C Hamano gits...@pobox.com wrote: yeah that's the goal. Though as we're in one transaction, as soon as we have an early exit, the

Re: [PATCHv3 6/6] refs.c: enable large transactions

2015-01-26 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: I do not see the problem in the code itself, but rather in understanding the code. I will send a follow up patch which makes it easier to follow by removing the early exit with no problem away. Taken as a whole the code may function correctly but the

[PATCHv3 6/6] refs.c: enable large transactions

2015-01-23 Thread Stefan Beller
By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. When closing the file descriptors early, we also need to write the values in early, if we don't want to reopen the files. Signed-off-by:

Re: [PATCHv3 6/6] refs.c: enable large transactions

2015-01-23 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. When closing the file descriptors early, we also need to write the values in early, if we don't

Re: [PATCHv3 6/6] refs.c: enable large transactions

2015-01-23 Thread Stefan Beller
On Fri, Jan 23, 2015 at 4:14 PM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: By closing the file descriptors after creating the lock file we are not limiting the size of the transaction by the number of available file descriptors. When closing the file

Re: [PATCHv3 6/6] refs.c: enable large transactions

2015-01-23 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: On Fri, Jan 23, 2015 at 4:14 PM, Junio C Hamano gits...@pobox.com wrote: yeah that's the goal. Though as we're in one transaction, as soon as we have an early exit, the transaction will abort. An early exit I am talking about is this: static int