Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Nguyen Thai Ngoc Duy
On Sun, Sep 16, 2012 at 3:13 PM, Ralf Thielow ralf.thie...@gmail.com wrote: + if (option_mirror || !option_bare) { + strbuf_reset(value); I think we should use a new strbuf local variable here to avoid resetting this. At least reviewers don't have to check if this statememt

Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch

2012-09-17 Thread Nguyen Thai Ngoc Duy
On Tue, Sep 18, 2012 at 3:08 AM, Junio C Hamano gits...@pobox.com wrote: Nguyen Thai Ngoc Duy pclo...@gmail.com writes: --mirror --single-branch combination does not look right. The heads/ part is missing.. What does it supposed to do in the first place? mirror is primarily about grabbing

Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch

2012-09-16 Thread Junio C Hamano
Ralf Thielow ralf.thie...@gmail.com writes: - add tests for the refspec installed by the clone command Thanks. +test_expect_success 'refspec contains all branches by default' ' + git clone file://$PWD dir_all There have been numerous on windows which should we use, $PWD or $(pwd)?