Re: [PATCHv4 00/27] Moving global state into the repository object (part 1)

2018-02-26 Thread Duy Nguyen
On Tue, Feb 27, 2018 at 3:50 AM, Stefan Beller wrote: >> The natural thing to do is move these to raw_object_store too (and >> repo_submodule_init needs to check submodule's config file). But one >> may argue these should be per-process instead of per-repo though. I >> don't know. But I thought I

Re: [PATCHv4 00/27] Moving global state into the repository object (part 1)

2018-02-26 Thread Stefan Beller
On Sat, Feb 24, 2018 at 7:00 AM, Duy Nguyen wrote: > I notice that there are a few global state (or configuration rather) > left after this: packed_git_window_size, packed_git_limit and > delta_base_cache_limit. These can be changed by $GIT_DIR/config, but > since it's still global, a submodule re

Re: [PATCHv4 00/27] Moving global state into the repository object (part 1)

2018-02-26 Thread Jonathan Tan
On Fri, 23 Feb 2018 16:47:27 -0800 Stefan Beller wrote: > v4: > * addressed feedback from the single patches (mostly nits) > * rebased on latest master The patches I looked at previously (patches 7, 15, 19, 22, and 24) look good to me.

Re: [PATCHv4 00/27] Moving global state into the repository object (part 1)

2018-02-24 Thread Duy Nguyen
I notice that there are a few global state (or configuration rather) left after this: packed_git_window_size, packed_git_limit and delta_base_cache_limit. These can be changed by $GIT_DIR/config, but since it's still global, a submodule repository will use the same settings of its super repository.

[PATCHv4 00/27] Moving global state into the repository object (part 1)

2018-02-23 Thread Stefan Beller
v4: * addressed feedback from the single patches (mostly nits) * rebased on latest master v3: * reverted back to use the repository for most of the functions (including unduplicating 'ignore_env') * rebased on master again (I lost that state when doing v2, as I did both rebase as well as conve