Re: [PATCHv4 09/17] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-23 Thread Stefan Beller
On Mon, May 22, 2017 at 10:59 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> diff --git a/submodule.c b/submodule.c >> index d3299e29c0..428c996c97 100644 >> --- a/submodule.c >> +++ b/submodule.c >> ... >> @@ -547,15 +543,16 @@ void

Re: [PATCHv4 09/17] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-22 Thread Junio C Hamano
Stefan Beller writes: > diff --git a/submodule.c b/submodule.c > index d3299e29c0..428c996c97 100644 > --- a/submodule.c > +++ b/submodule.c > ... > @@ -547,15 +543,16 @@ void show_submodule_inline_diff(FILE *f, const char > *path, > if (right) > new =

[PATCHv4 09/17] submodule.c: convert show_submodule_summary to use emit_line_fmt

2017-05-22 Thread Stefan Beller
In a later patch, I want to propose an option to detect moved lines in a diff, which cannot be done in a one-pass over the diff. Instead we need to go over the whole diff twice, because we cannot detect the first line of the two corresponding lines (+ and -) that got moved. So to prepare the diff