Re: [PATCHv6 0/8] fetch submodules in parallel

2015-10-02 Thread Junio C Hamano
Stefan Beller writes: > * renamed return_value_fn to task_finished_fn It made interdiff noisier but I think it gives us a good end result. > * the main loop of the parallel processing was first adapted to Junios > suggestion, > but Jonathan pointed out more improvements. We can get rid of

Re: [PATCHv6 0/8] fetch submodules in parallel

2015-10-01 Thread Stefan Beller
On Thu, Oct 1, 2015 at 11:55 AM, Ramsay Jones wrote: > Hi Stefan, > >> >> - if (!pp->get_next_task(pp->data, >> + if (!pp->get_next_task(&pp->children[i].data, >> &pp->children[i].process, >> -&pp->children[i].err)) >> +

Re: [PATCHv6 0/8] fetch submodules in parallel

2015-10-01 Thread Ramsay Jones
Hi Stefan, On 01/10/15 02:54, Stefan Beller wrote: [snip] While skimming the interdiff for this series, ... > diff --git a/run-command.c b/run-command.c > index df84985..28048a7 100644 > --- a/run-command.c > +++ b/run-command.c > @@ -863,12 +863,13 @@ struct parallel_processes { > > get

[PATCHv6 0/8] fetch submodules in parallel

2015-09-30 Thread Stefan Beller
This replaces sb/submodule-parallel-fetch once again. Changes are only in patch 5,6,7 (5: reverse popping, 6: see below, 7: adapt to changes of 6). Junio wrote: > > + if (pp->return_value(pp->data, &pp->children[i].process, > > + &pp->children[i].err, c