Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-05 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Thu, Aug 02, 2018 at 11:21:44PM -0700, Jonathan Nieder wrote: >> Jeff King wrote: >>> I guess you could even replace "COCCI_COMBINED" with "COCCI_PATCH" in >>> most of the targets, and that would let people do individual: >>> >>> make

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-03 Thread Jeff King
On Thu, Aug 02, 2018 at 11:21:44PM -0700, Jonathan Nieder wrote: > > diff --git a/Makefile b/Makefile > > index d616c0412..86fdcf567 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -2674,15 +2674,17 @@ COCCI_SOURCES = $(filter-out > > sha1collisiondetection/%,$(C_SOURCES)) > > else > >

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-03 Thread Julia Lawall
By the way, you can see my performance numbers here: https://www.usenix.org/system/files/conference/atc18/atc18-lawall.pdf Page 8, figures 4 and 5. julia

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-03 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Thu, Aug 02, 2018 at 02:01:55PM -0400, Jeff King wrote: >> I suspect if we go with the one-spatch-per-source route, though, that we >> could do this just with regular make rules. > > Yeah, it's pretty straightforward: > > diff --git a/Makefile b/Makefile > index

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread Ævar Arnfjörð Bjarmason
On Thu, Aug 02 2018, Jeff King wrote: > On Thu, Aug 02, 2018 at 01:55:22PM +0200, SZEDER Gábor wrote: > >> Let's add a bit of Makefile metaprogramming to generate finer-grained >> make targets applying one semantic patch to only a single source file, >> and specify these as dependencies of the

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread Jeff King
On Thu, Aug 02, 2018 at 03:46:08PM -0400, Eric Sunshine wrote: > On Thu, Aug 2, 2018 at 2:02 PM Jeff King wrote: > > On Thu, Aug 02, 2018 at 01:55:22PM +0200, SZEDER Gábor wrote: > > > This approach uses $(eval), which we haven't used in any of our > > > Makefiles yet. I wonder whether

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread Eric Sunshine
On Thu, Aug 2, 2018 at 2:02 PM Jeff King wrote: > On Thu, Aug 02, 2018 at 01:55:22PM +0200, SZEDER Gábor wrote: > > This approach uses $(eval), which we haven't used in any of our > > Makefiles yet. I wonder whether it's portable enough. And it's > > ugly and complicated. > > I

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread Jeff King
On Thu, Aug 02, 2018 at 02:01:55PM -0400, Jeff King wrote: > I suspect if we go with the one-spatch-per-source route, though, that we > could do this just with regular make rules. Yeah, it's pretty straightforward: diff --git a/Makefile b/Makefile index d616c0412..86fdcf567 100644 ---

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread Jeff King
On Thu, Aug 02, 2018 at 01:55:22PM +0200, SZEDER Gábor wrote: > Let's add a bit of Makefile metaprogramming to generate finer-grained > make targets applying one semantic patch to only a single source file, > and specify these as dependencies of the targets applying one semantic > patch to all

Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread René Scharfe
Am 02.08.2018 um 13:55 schrieb SZEDER Gábor: > Let's add a bit of Makefile metaprogramming to generate finer-grained > make targets applying one semantic patch to only a single source file, > and specify these as dependencies of the targets applying one semantic > patch to all source files. This

[PoC] coccinelle: make Coccinelle-related make targets more fine-grained

2018-08-02 Thread SZEDER Gábor
those disadvantages... Also available at: https://github.com/szeder/git make-coccicheck-finegrained -- >8 -- Subject: [PATCH] [PoC] coccinelle: make Coccinelle-related make targets more fine-grained When running 'make coccicheck', each semantic patch is applied to all source fi