Re: [RFC/PATCH] Add the NO_SENTINEL build variable

Jonathan Nieder wrote: Ramsay Jones wrote: One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute? Would it make sense for the ifdef in

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

Ramsay Jones ram...@ramsay1.demon.co.uk writes: Jonathan Nieder wrote: Ramsay Jones wrote: One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute?

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

Ramsay Jones ram...@ramsay1.demon.co.uk writes: diff --git a/git-compat-util.h b/git-compat-util.h index 9f1eaca..e846e01 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -300,6 +300,12 @@ extern char *gitbasename(char *); #endif #endif +#if defined(__GNUC__)

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

Junio C Hamano gits...@pobox.com writes: Also do we know what version of GCC started supporting this attribute? http://gcc.gnu.org/gcc-4.0/changes.html mentions it in New Languages and Language specific improvements section, but the page also says The latest release in the 4.0 release series

[RFC/PATCH] Add the NO_SENTINEL build variable

Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Is this, or something like it, too ugly for you to squash into your patch? :-D ATB, Ramsay

Re: [RFC/PATCH] Add the NO_SENTINEL build variable

Ramsay Jones wrote: One of the three gcc compilers that I use does not understand the sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute? Would it make sense for the ifdef in git-compat-util.h to be keyed on