Re: [RFC/PATCH] Makefile: suppress some cppcheck false-positives

On Fri, Dec 16, 2016 at 10:43:48AM -0800, Junio C Hamano wrote: > > diff --git a/nedmalloc.supp b/nedmalloc.supp > [...] > > diff --git a/regcomp.supp b/regcomp.supp > > Yuck for both files for multiple reasons. > > I do not think it is a good idea to allow these files to clutter the >

Re: [RFC/PATCH] Makefile: suppress some cppcheck false-positives

Chris Packham writes: > -CPPCHECK_FLAGS = --force --quiet --inline-suppr $(if > $(CPPCHECK_ADD),--enable=$(CPPCHECK_ADD)) > +CPPCHECK_SUPP = --suppressions-list=nedmalloc.supp \ > + --suppressions-list=regcomp.supp > + > +CPPCHECK_FLAGS = --force --quiet

[RFC/PATCH] Makefile: suppress some cppcheck false-positives

Pass a list of suppressions to cppcheck so that legitimate errors are more obvious. Signed-off-by: Chris Packham --- On Thu, Dec 15, 2016 at 12:24 AM, Jeff King wrote: > The patch itself is OK to me, I guess. The interesting part will be > whether people