Re: [RFC/PATCH] Port branch.c to use ref-filter APIs

2015-07-29 Thread Karthik Nayak
On Tue, Jul 28, 2015 at 11:23 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: On Tue, Jul 28, 2015 at 7:05 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Ideally, you could also have a modifier atom %(alignleft) [...] This could work

[RFC/PATCH] Port branch.c to use ref-filter APIs

2015-07-28 Thread Karthik Nayak
This is part of my GSoC project to unify git tag -l, git branch -l, git for-each-ref. This patch series is continued from: Gmane (v6) http://article.gmane.org/gmane.comp.version-control.git/274726 This is a RFC version and I'm sending to ensure that I'm on the right path. This version also

Re: [RFC/PATCH] Port branch.c to use ref-filter APIs

2015-07-28 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: This version also doesn't use the printing options provided by branch.c. Do you mean provided by ref-filter.{c,h}? I wanted to discuss how exactly to go about that, because in branch.c, we might need to change the --format based on attributes such

Re: [RFC/PATCH] Port branch.c to use ref-filter APIs

2015-07-28 Thread Karthik Nayak
On Tue, Jul 28, 2015 at 7:05 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Karthik Nayak karthik@gmail.com writes: This version also doesn't use the printing options provided by branch.c. Do you mean provided by ref-filter.{c,h}? Yes! my bad. I wanted to discuss how exactly to

Re: [RFC/PATCH] Port branch.c to use ref-filter APIs

2015-07-28 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: On Tue, Jul 28, 2015 at 7:05 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Ideally, you could also have a modifier atom %(alignleft) [...] This could work for refname, as each ref_array_item holds the refname, But other atoms are only