Re: [RFC/PATCH] config: add core.trustmtime

On Wed, Dec 2, 2015 at 8:28 PM, Duy Nguyen wrote: > On Wed, Nov 25, 2015 at 10:00 AM, Ævar Arnfjörð Bjarmason > wrote: >> Aside from the slight hassle of enabling this and keeping it enabled >> this feature is great. It's sped up "git status" across the board

Re: [RFC/PATCH] config: add core.trustmtime

On Wed, Nov 25, 2015 at 10:00 AM, Ævar Arnfjörð Bjarmason wrote: > Aside from the slight hassle of enabling this and keeping it enabled > this feature is great. It's sped up "git status" across the board by > about 40%. Slightly less than that on faster spinning disks, slightly

Re: [RFC/PATCH] config: add core.trustmtime

Ævar Arnfjörð Bjarmason writes: > Maybe I'm missing some really common breakage with st_mtime on some > system, but having a feature the user explicitly enables turn itself > off and doing FS-testing that takes 10 seconds when it's enabled seems > like the wrong default to me.

Re: [RFC/PATCH] config: add core.trustmtime

On Mon, Nov 30, 2015 at 8:05 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Maybe I'm missing some really common breakage with st_mtime on some >> system, but having a feature the user explicitly enables turn itself >> off and doing

Re: [RFC/PATCH] config: add core.trustmtime

On 11/30/2015 08:05 PM, Junio C Hamano wrote: Ævar Arnfjörð Bjarmason writes: Maybe I'm missing some really common breakage with st_mtime on some system, but having a feature the user explicitly enables turn itself off and doing FS-testing that takes 10 seconds when it's

Re: [RFC/PATCH] config: add core.trustmtime

On Thu, Nov 26, 2015 at 6:21 AM, Christian Couder wrote: > Hi Duy, > > On Wed, Nov 25, 2015 at 8:51 PM, Duy Nguyen wrote: >> On Wed, Nov 25, 2015 at 10:00 AM, Ævar Arnfjörð Bjarmason >> wrote: >>> On Wed, Nov 25, 2015 at 7:35 AM,

Re: [RFC/PATCH] config: add core.trustmtime

On Thu, Nov 26, 2015 at 6:53 PM, Duy Nguyen wrote: > On Thu, Nov 26, 2015 at 6:21 AM, Christian Couder > wrote: >> I am wondering why you didn't make it by default run the mtime checks >> when a kernel change is detected. Maybe that would be better

Re: [RFC/PATCH] config: add core.trustmtime

On Wed, Nov 25, 2015 at 10:00 AM, Ævar Arnfjörð Bjarmason wrote: > On Wed, Nov 25, 2015 at 7:35 AM, Christian Couder > wrote: >> At Booking.com we know that mtime works everywhere and we don't >> want the untracked cache to stop working when a kernel

Re: [RFC/PATCH] config: add core.trustmtime

Hi Johannes, On Wed, Nov 25, 2015 at 11:25 AM, Johannes Schindelin wrote: > Hi Christian, > > On Wed, 25 Nov 2015, Christian Couder wrote: > >> diff --git a/config.c b/config.c >> index 248a21a..d720b1f 100644 >> --- a/config.c >> +++ b/config.c >> @@ -691,6 +691,13

Re: [RFC/PATCH] config: add core.trustmtime

Hi Christian, On Wed, 25 Nov 2015, Christian Couder wrote: > diff --git a/config.c b/config.c > index 248a21a..d720b1f 100644 > --- a/config.c > +++ b/config.c > @@ -691,6 +691,13 @@ static int git_default_core_config(const char *var, > const char *value) > trust_ctime =

Re: [RFC/PATCH] config: add core.trustmtime

On Wed, Nov 25, 2015 at 7:35 AM, Christian Couder wrote: > At Booking.com we know that mtime works everywhere and we don't > want the untracked cache to stop working when a kernel is upgraded > or when the repo is copied to a machine with a different kernel. > I will

Re: [RFC/PATCH] config: add core.trustmtime

Hi Duy, On Wed, Nov 25, 2015 at 8:51 PM, Duy Nguyen wrote: > On Wed, Nov 25, 2015 at 10:00 AM, Ævar Arnfjörð Bjarmason > wrote: >> On Wed, Nov 25, 2015 at 7:35 AM, Christian Couder >> wrote: >>> At Booking.com we know that mtime

[RFC/PATCH] config: add core.trustmtime

When we know that mtime is fully supported by the environment, we don't want any slow down because we used --untracked-cache rather than --force-untracked-cache, and we don't want untracked cache to stop working because we updated a kernel. Also when we know that mtime is not supported by the