Re: [RFC/PATCH 01/48] builtin/apply: avoid parameter shadowing 'p_value' global

On Thu, Mar 10, 2016 at 1:54 AM, Duy Nguyen wrote: > On Thu, Mar 10, 2016 at 6:27 AM, Junio C Hamano wrote: >> Christian Couder writes: >> >>> Signed-off-by: Christian Couder >>> --- >>> builtin/apply.c

Re: [RFC/PATCH 01/48] builtin/apply: avoid parameter shadowing 'p_value' global

On Thu, Mar 10, 2016 at 6:27 AM, Junio C Hamano wrote: > Christian Couder writes: > >> Signed-off-by: Christian Couder >> --- >> builtin/apply.c | 24 >> 1 file changed, 12 insertions(+), 12

Re: [RFC/PATCH 01/48] builtin/apply: avoid parameter shadowing 'p_value' global

Christian Couder writes: > Signed-off-by: Christian Couder > --- > builtin/apply.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) To be honest, I have to say that I do not like this change from

[RFC/PATCH 01/48] builtin/apply: avoid parameter shadowing 'p_value' global

Signed-off-by: Christian Couder --- builtin/apply.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/builtin/apply.c b/builtin/apply.c index 42c610e..7d9be63 100644 --- a/builtin/apply.c +++ b/builtin/apply.c @@ -469,7 +469,7