Re: [RFC/PATCH 1/9] tag: libify parse_opt_points_at()

2015-06-09 Thread Karthik Nayak
On 06/09/2015 12:30 AM, Junio C Hamano wrote: This feels way too specialized to live as part of parse_options infrastructure. The existing caller(s) may want to use this callback for parsing points-at option they have, but is that the only plausible use of this callback? It looks to be usable

Re: [RFC/PATCH 1/9] tag: libify parse_opt_points_at()

2015-06-08 Thread Junio C Hamano
Karthik Nayak karthik@gmail.com writes: diff --git a/parse-options-cb.c b/parse-options-cb.c index be8c413..a4d294d 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c @@ -4,6 +4,7 @@ #include commit.h #include color.h #include string-list.h +#include sha1-array.h ... +int

[RFC/PATCH 1/9] tag: libify parse_opt_points_at()

2015-06-06 Thread Karthik Nayak
Moving 'parse_opt_points_at()' from 'tag.c' to a common location, in preparation for using it in 'ref-filter'. Based-on-patch-by: Jeff King p...@peff.net Mentored-by: Christian Couder christian.cou...@gmail.com Mentored-by: Matthieu Moy matthieu@grenoble-inp.fr Signed-off-by: Karthik Nayak