Re: [RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-27 Thread Jeff King
On Wed, May 27, 2015 at 12:01:50PM -0700, Stefan Beller wrote: Interesting choice for the short option (-v would be nice, but obviously it is taken). Do we want to delay on claiming the short-and-sweet 'y' until we are sure this is something people will use a lot? In an ideal world, it is

Re: [RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-27 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, May 26, 2015 at 03:01:09PM -0700, Stefan Beller wrote: +OPT_STRING('y', transport-version, transport_version, + N_(transport-version), + N_(specify transport version to be used)), Interesting choice for the short

Re: [RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-27 Thread Stefan Beller
On Tue, May 26, 2015 at 11:39 PM, Jeff King p...@peff.net wrote: On Tue, May 26, 2015 at 03:01:09PM -0700, Stefan Beller wrote: + OPT_STRING('y', transport-version, transport_version, +N_(transport-version), +N_(specify transport version to be used)),

Re: [RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-27 Thread Jeff King
On Tue, May 26, 2015 at 03:01:09PM -0700, Stefan Beller wrote: + OPT_STRING('y', transport-version, transport_version, +N_(transport-version), +N_(specify transport version to be used)), Interesting choice for the short option (-v would be nice, but

[RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-26 Thread Stefan Beller
The transport version set via command line argument in git fetch takes precedence over the configured version. Signed-off-by: Stefan Beller sbel...@google.com --- builtin/fetch.c| 6 ++ remote.c | 2 ++ remote.h | 2 ++ transport-helper.c | 1 + transport.c