Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-27 Thread Jeff King
On Tue, May 26, 2015 at 10:09:45PM -0700, Junio C Hamano wrote: Stefan Beller sbel...@google.com writes: On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano gits...@pobox.com wrote: if (...-version 2) { ... append -%d ... } involved. Oh! I see

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-27 Thread Jeff King
On Tue, May 26, 2015 at 03:01:12PM -0700, Stefan Beller wrote: Signed-off-by: Stefan Beller sbel...@google.com --- transport.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/transport.c b/transport.c index 3ef15f6..33644a6 100644 --- a/transport.c

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller sbel...@google.com wrote: Signed-off-by: Stefan Beller sbel...@google.com --- diff --git a/transport.c b/transport.c index 3ef15f6..33644a6 100644 --- a/transport.c +++ b/transport.c @@ -496,15 +496,29 @@ static int set_git_option(struct

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano gits...@pobox.com wrote: if (...-version 2) { ... append -%d ... } involved. Oh! I see here you would count the current one as 1, which has no number extension, and

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Stefan Beller
On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: + if (transport-smart_options + transport-smart_options-transport_version) { + buf = xmalloc(strlen(remote_program) + 12); + sprintf(buf,

[RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller sbel...@google.com --- transport.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/transport.c b/transport.c index 3ef15f6..33644a6 100644 --- a/transport.c +++ b/transport.c @@ -496,15 +496,29 @@ static int

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Junio C Hamano
Stefan Beller sbel...@google.com writes: + if (transport-smart_options + transport-smart_options-transport_version) { + buf = xmalloc(strlen(remote_program) + 12); + sprintf(buf, %s-%d, remote_program, +