Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On Sat, Apr 7, 2018 at 4:56 AM, Eric Sunshine wrote: > The existing git-stash requires a working directory: > > % git stash list > fatal: not a git repository (or any of the parent directories): .git > % Correction on the error message: % git stash list fatal: git-stash

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On Tue, Apr 3, 2018 at 5:38 PM, Paul-Sebastian Ungureanu wrote: > On 25.03.2018 10:08, Eric Sunshine wrote: >> On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu >> wrote: >>> diff --git a/git.c b/git.c >>> @@ -466,6

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On 25.03.2018 10:08, Eric Sunshine wrote: On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu wrote: Currently, because git stash is not fully converted to C, I introduced a new helper that will hold the converted commands. --- diff --git

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

Hi Thomas, On Mon, 26 Mar 2018, Thomas Gummerer wrote: > On 03/26, Johannes Schindelin wrote: > > > > On Sun, 25 Mar 2018, Eric Sunshine wrote: > > > > > On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu > > > wrote: > > > > Currently, because git

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On 03/26, Johannes Schindelin wrote: > Hi Eric, > > On Sun, 25 Mar 2018, Eric Sunshine wrote: > > > On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu > > wrote: > > > Currently, because git stash is not fully converted to C, I > > > introduced a new

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

Hi Eric, On Sun, 25 Mar 2018, Eric Sunshine wrote: > On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu > wrote: > > Currently, because git stash is not fully converted to C, I > > introduced a new helper that will hold the converted commands. > > --- >

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On 03/24, Paul-Sebastian Ungureanu wrote: > Currently, because git stash is not fully converted to C, I > introduced a new helper that will hold the converted commands. Missing sign-off? I think it's a good idea to sign off your work even for RFC patches that you don't expect to be applied. If

Re: [RFC][PATCH] git-stash: convert git stash list to C builtin

On Sat, Mar 24, 2018 at 2:23 PM, Paul-Sebastian Ungureanu wrote: > Currently, because git stash is not fully converted to C, I > introduced a new helper that will hold the converted commands. > --- > diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c

[RFC][PATCH] git-stash: convert git stash list to C builtin

Currently, because git stash is not fully converted to C, I introduced a new helper that will hold the converted commands. --- Makefile| 1 + builtin.h | 1 + builtin/stash--helper.c | 52 + git-stash.sh| 7