The test suite needs to be run on different platforms.
As it may be difficult for contributors to catch syntax
which work on GNU/linux, but is unportable, make a quick check
for the most common problems.
"sed -i", "echo -n" or "array in shell scripts"
This list is not complete, and may need to be e
On 12/02/2012 02:17 PM, Torsten Bögershausen wrote:
> The test suite needs to be run on different platforms.
> As it may be difficult for contributors to catch syntax
> which work on GNU/linux, but is unportable, make a quick check
> for the most common problems.
> "sed -i", "echo -n" or "array in
Torsten Bögershausen writes:
> The test suite needs to be run on different platforms.
> As it may be difficult for contributors to catch syntax
> which work on GNU/linux, but is unportable, make a quick check
> for the most common problems.
> "sed -i", "echo -n" or "array in shell scripts"
> This
On Mon, Dec 3, 2012 at 11:56 PM, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> The test suite needs to be run on different platforms.
>> As it may be difficult for contributors to catch syntax
>> which work on GNU/linux, but is unportable, make a quick check
>> for the most common pro
Nguyen Thai Ngoc Duy writes:
>> This (once it gets cleaned up to reduce false positives) belongs to
>> "cd t && make test-lint".
>
> Or a project commit hook?
Surely. It is OK to have "cd t && make test-lint" in your
pre-commit hook.
A few more things in addition to what Torsten's script attem
On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano wrote:
>> Or a project commit hook?
>
> Surely. It is OK to have "cd t && make test-lint" in your
> pre-commit hook.
No, what I meant is a shared pre-commit script that all git devs are
encouraged (or forced) to install so bugs are found locally rat
Nguyen Thai Ngoc Duy writes:
> On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano wrote:
>>> Or a project commit hook?
>>
>> Surely. It is OK to have "cd t && make test-lint" in your
>> pre-commit hook.
>
> No, what I meant is a shared pre-commit script that all git devs are
> encouraged (or forced
On Wed, Dec 05, 2012 at 12:43:30PM +0700, Nguyen Thai Ngoc Duy wrote:
> On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano wrote:
> >> Or a project commit hook?
> >
> > Surely. It is OK to have "cd t && make test-lint" in your
> > pre-commit hook.
>
> No, what I meant is a shared pre-commit script
On Wed, Dec 05, 2012 at 02:30:56AM -0500, Jeff King wrote:
> Anyway, I do think a "shell portability lint" would be a great addition
> to "test-lint", but I am slightly skeptical that it will be easy to
> write a good one that does not have false positives. Still, there may be
> some low-hanging f
On 2012/12/04 20:39 , Junio C Hamano wrote:
A few more things in addition to what Torsten's script attempts to
catch that we would want to catch are:
[...]
> * Do not write ERE with backslashes and expect "grep" to grok them;
> that's GNUism. e.g.
>
>grep "^\(author\|committer\) "
Jeff King writes:
> You would want a "check shell script portability" script, and you would
> probably want to run it:
>
> - on the regular built scripts; possibly during build time (I have done
> this before with "perl -c" for perl scripts and it is reasonably
> successful). Or in a te
11 matches
Mail list logo
