Re: [RFC] Contributing to Git (on Windows)

Hi Jonathan, On Mon, 5 Mar 2018, Jonathan Nieder wrote: > BTW, thanks again for writing and submitting this document. It can't > land soon enough. :) It landed: https://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md Ciao, Dscho

Re: [RFC] Contributing to Git (on Windows)

Johannes Schindelin writes: >> > "What if they say my code is not good enough?" >> >> Sure, though there is something implied in what is Junio is saying >> that is useful for such people. >> >> It is patience. It is the message that if you miss a portability bug,

Re: [RFC] Contributing to Git (on Windows)

On Mon, Mar 5, 2018 at 1:26 PM, Jonathan Nieder wrote: > Johannes Schindelin wrote: >> The Google gang (you & Junio included) uses Linux. Peff uses Linux. From >> what I can see Duy, Eric and Jake use Linux. That covers already the most >> active reviewers right there. > > We

Re: [RFC] Contributing to Git (on Windows)

Hi again, Back on topic, some quick clarifications to tie up loose ends. Also I want to thank you for continuing to push the project to work better (especially to work better for newcomers). We don't seem to have a habit of saying often enough how important that goal is. Of course we'll

Re: [RFC] Contributing to Git (on Windows)

Derrick Stolee wrote: > Dereck Stolee wrote: > > nit: s/Dereck/Derrick/ Is my outgoing email name misspelled, or do you have > a misspelled contact info for me? A manual typo. Sorry about that. [... a bunch snipped ...] > I have a habit of being too loose in language around lawyer-speak. I

Re: [RFC] Contributing to Git (on Windows)

Hi Dscho, Johannes Schindelin wrote: > On Sat, 3 Mar 2018, Jonathan Nieder wrote: >> Hopefully the clarifications and suggestions higher in this message >> help. If they don't, then I'm nervous about our ability to understand >> each other. > > Okay, let me state what I think the goal of this

Re: [RFC] Contributing to Git (on Windows)

Hi Jonathan, On Sat, 3 Mar 2018, Jonathan Nieder wrote: > Johannes Schindelin wrote: > >> Jonathan Nieder writes: > >>> Dereck Stolee wrote: > > +Test Your Changes on Linux > +-- > + > +It can be important to work directly on the

Re: [RFC] Contributing to Git (on Windows)

I really appreciate the feedback on this document, Jonathan. On 3/3/2018 1:27 PM, Jonathan Nieder wrote: Hi Dscho, Johannes Schindelin wrote: Jonathan Nieder writes: Dereck Stolee wrote: nit: s/Dereck/Derrick/ Is my outgoing email name misspelled, or do you have a

Re: [RFC] Contributing to Git (on Windows)

Hi Dscho, Johannes Schindelin wrote: >> Jonathan Nieder writes: >>> Dereck Stolee wrote: +Test Your Changes on Linux +-- + +It can be important to work directly on the [core Git codebase](https://github.com/git/git), +such as

Re: [RFC] Contributing to Git (on Windows)

Hi, On Fri, 2 Mar 2018, Junio C Hamano wrote: > Jonathan Nieder writes: > > >> +Test Your Changes on Linux > >> +-- > >> + > >> +It can be important to work directly on the [core Git > >> codebase](https://github.com/git/git), +such as a recent

Re: [RFC] Contributing to Git (on Windows)

Jonathan Nieder writes: >> +When adding a helper, be sure to add a line to `t/Makefile` and to the >> `.gitignore` for the >> +binary file you add. The Git community prefers functional tests using the >> full `git` >> +executable, so be sure the test helper is required. > >

Re: [RFC] Contributing to Git (on Windows)

On 3/1/2018 11:44 PM, Jonathan Nieder wrote: Hi, Derrick Stolee wrote: Now, we'd like to make that document publicly available. These steps are focused on a Windows user, so we propose putting them in the git-for-windows/git repo under CONTRIBUTING.md. I have a pull request open for feedback

Re: [RFC] Contributing to Git (on Windows)

Hi, Derrick Stolee wrote: > Now, we'd like to make that document publicly available. These steps are > focused on a Windows user, so we propose putting them in the > git-for-windows/git repo under CONTRIBUTING.md. I have a pull request open > for feedback [1]. I'll read comments on that PR or in

[RFC] Contributing to Git (on Windows)

We (Git devs at Microsoft) have had several people start contributing to Git over the past few years (I'm the most-recent addition). As we on-boarded to Git development on our Windows machines, we collected our setup steps on an internal wiki page. Now, we'd like to make that document