Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Thu, Apr 28, 2016 at 02:05:20PM +0200, Lars Schneider wrote: > I am no expert in the Submodule code but I think the cloning of > the submodules is not yet guarded with sanitize_submodule_env [3]. > That means the submodule is cloned with the GIT_CONFIG_PARAMETERS > of the super project. That

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Thu, Apr 28, 2016 at 08:05:04AM -0400, Jeff King wrote: > So AFAICT 14111fc49 is totally broken. It doesn't actually work for > git-submodule (because of the missing export), nor for git-fetch > (because that skips the shell script), and the one case we are testing > already worked without it

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

> On 28 Apr 2016, at 13:25, Jeff King wrote: > > On Thu, Apr 28, 2016 at 01:06:45PM +0200, Lars Schneider wrote: > >> I got my Git-LFS use case working with the patch below. >> For me it was necessary to export GIT_CONFIG_PARAMETERS >> to make it available to the Git process if

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Thu, Apr 28, 2016 at 07:25:11AM -0400, Jeff King wrote: > > diff --git a/git-submodule.sh b/git-submodule.sh > > index 2a84d7e..b02f5b9 100755 > > --- a/git-submodule.sh > > +++ b/git-submodule.sh > > @@ -199,7 +199,7 @@ sanitize_submodule_env() > > { > > sanitized_config=$(git

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Thu, Apr 28, 2016 at 01:06:45PM +0200, Lars Schneider wrote: > I got my Git-LFS use case working with the patch below. > For me it was necessary to export GIT_CONFIG_PARAMETERS > to make it available to the Git process if the process is > invoked as follows [2]: > >

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

> On 25 Apr 2016, at 23:24, Jeff King wrote: > > On Mon, Apr 25, 2016 at 01:59:03PM -0700, Jacob Keller wrote: > However, I noticed that git config command line instructions such as "-c filter.lfs.smudge=" are not passed to Git submodule operations. Thus this does

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Mon, Apr 25, 2016 at 01:59:03PM -0700, Jacob Keller wrote: > >> However, I noticed that git config command line instructions such as > >> "-c filter.lfs.smudge=" are not passed to Git submodule operations. Thus > >> this does not work as expected: > >> > >> git -c filter.lfs.smudge= -c

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Mon, Apr 25, 2016 at 05:24:50PM -0400, Jeff King wrote: > It does mean that somebody would be stuck who really wanted to run the > smudge filter in their local repo, but for some reason not in the > subrepos. I am trying to think of a case in which that might be > security-relevant if you

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Mon, Apr 25, 2016 at 10:02 AM, Stefan Beller wrote: > On Mon, Apr 25, 2016 at 3:39 AM, Lars Schneider > wrote: >> Hi, >> >> a few folks from the Git LFS project and I try to make cloning of >> repositories >> with a lot of LFS files faster. >> >>

Re: [RFC] How to pass Git config command line instructions to Submodule commands?

On Mon, Apr 25, 2016 at 3:39 AM, Lars Schneider wrote: > Hi, > > a few folks from the Git LFS project and I try to make cloning of repositories > with a lot of LFS files faster. > > The core problem is that Git LFS uses a Git smudge filter to replace LFS > pointers with

[RFC] How to pass Git config command line instructions to Submodule commands?

Hi, a few folks from the Git LFS project and I try to make cloning of repositories with a lot of LFS files faster. The core problem is that Git LFS uses a Git smudge filter to replace LFS pointers with the actual file content. Right now, a smudge filter can only be executed on an individual