Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Junio C Hamano
Junio C Hamano writes: > I wonder if we can do something like > ... > to tentatively give a message without permanently wasting the > vertical space. Learning from 13e4760a ("recv_sideband: Do not use ANSI escape sequence on dumb terminals.", 2008-01-08), I think the above should be more like th

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Stefan Beller
On Wed, Nov 15, 2017 at 4:33 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> I wonder if we can do something like >>> >>> git_spawn_editor() >>> { >>> const char *EL = "\033[K"; /* Erase in Line */ >>> >>> /* notice the lack of terminating L

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Junio C Hamano
Stefan Beller writes: >> I wonder if we can do something like >> >> git_spawn_editor() >> { >> const char *EL = "\033[K"; /* Erase in Line */ >> >> /* notice the lack of terminating LF */ >> fprintf(stderr, "Launching your editor..."

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Stefan Beller
On Wed, Nov 15, 2017 at 2:32 PM, Junio C Hamano wrote: > Lars Schneider writes: > >> However, if you configure an editor that runs outside your terminal window >> then >> you might run into the following problem: >> Git opens the editor but the editor is the background or on another screen >> a

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Junio C Hamano
Lars Schneider writes: > However, if you configure an editor that runs outside your terminal window > then > you might run into the following problem: > Git opens the editor but the editor is the background or on another screen > and > consequently you don't see the editor. You only see the G

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Stefan Beller
On Wed, Nov 15, 2017 at 10:07 AM, Lars Schneider wrote: >> Can this be put in a wrapper that opens the text editor? >> The wrapper would print these lines and then open the text editor; >> depending on the operating system, there might even be a command to >> focus on that editor window. > > Yeah

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Lars Schneider
> On 15 Nov 2017, at 18:51, Stefan Beller wrote: > > On Wed, Nov 15, 2017 at 7:08 AM, Lars Schneider > wrote: >> Hi, >> >> Git gathers user input via text editor in certain commands (e.g. "git >> commit"). >> If you configure a text based editor, such as vi, then this works great as >> the >

Re: [RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Stefan Beller
On Wed, Nov 15, 2017 at 7:08 AM, Lars Schneider wrote: > Hi, > > Git gathers user input via text editor in certain commands (e.g. "git > commit"). > If you configure a text based editor, such as vi, then this works great as the > editor is opened in your terminal window in the foreground and in f

[RFC] Indicate that Git waits for user input via editor

2017-11-15 Thread Lars Schneider
Hi, Git gathers user input via text editor in certain commands (e.g. "git commit"). If you configure a text based editor, such as vi, then this works great as the editor is opened in your terminal window in the foreground and in focus. However, if you configure an editor that runs outside your t