Re: [RFC] cover-at-tip

2017-11-13 Thread Nicolas Morey-Chaisemartin
Le 13/11/2017 à 11:30, Junio C Hamano a écrit : > Junio C Hamano writes: > >> Nicolas Morey-Chaisemartin writes: >> >>> I agree this is a "am" job. Was just wondering if reusing some of >>> the code from apply (and move it so it makes more sense)

Re: [RFC] cover-at-tip

2017-11-13 Thread Junio C Hamano
Junio C Hamano writes: > Nicolas Morey-Chaisemartin writes: > >> I agree this is a "am" job. Was just wondering if reusing some of >> the code from apply (and move it so it makes more sense) wouldnd't >> make more sense than rewriting a patch

Re: [RFC] cover-at-tip

2017-11-13 Thread Junio C Hamano
Nicolas Morey-Chaisemartin writes: > I agree this is a "am" job. Was just wondering if reusing some of > the code from apply (and move it so it makes more sense) wouldnd't > make more sense than rewriting a patch detection function. Yes, I understood that and have

Re: [RFC] cover-at-tip

2017-11-12 Thread Nicolas Morey-Chaisemartin
Le 10/11/2017 à 19:22, Junio C Hamano a écrit : > Nicolas Morey-Chaisemartin writes: > >> I would need to add "some" level of parsing to am.c to make sure >> the patch content is just garbage and that there are no actual >> hunks for that. >> >> I did not find any

Re: [RFC] cover-at-tip

2017-11-10 Thread Jonathan Tan
On Fri, 10 Nov 2017 16:37:49 +0100 Nicolas Morey-Chaisemartin wrote: > > Hi, > > > > I'm starting to look into the cover-at-tip topic that I found in the > > leftover bits (http://www.spinics.net/lists/git/msg259573.html) Thanks - I personally would find this very

Re: [RFC] cover-at-tip

2017-11-10 Thread Junio C Hamano
Nicolas Morey-Chaisemartin writes: > I would need to add "some" level of parsing to am.c to make sure > the patch content is just garbage and that there are no actual > hunks for that. > > I did not find any public API that would allow me to do that, > although

Re: [RFC] cover-at-tip

2017-11-10 Thread Nicolas Morey-Chaisemartin
Le 10/11/2017 à 11:24, Nicolas Morey-Chaisemartin a écrit : > Hi, > > I'm starting to look into the cover-at-tip topic that I found in the leftover > bits (http://www.spinics.net/lists/git/msg259573.html) > > Here's a first draft of a patch that adds support for format-patch > --cover-at-tip.

[RFC] cover-at-tip

2017-11-10 Thread Nicolas Morey-Chaisemartin
Hi, I'm starting to look into the cover-at-tip topic that I found in the leftover bits (http://www.spinics.net/lists/git/msg259573.html) Here's a first draft of a patch that adds support for format-patch --cover-at-tip. It compiles and works in my nice and user firnedly test case. Just wanted