Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

Junio C Hamano writes: > That leaves us to something along this line... > >> (3) Add a method "test_must_fail_or_die" to >> "test-lib-functions.sh". This method accepts exit codes 129> too. Use the new method in t5516. > > ... but I have to wonder if 129

Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

I think the following happens: 1. The remote upload-pack finds out "not our ref" 2. The remote send a response and close the pipe 3. fetch-pack still tries to write commands to the remote upload-pack 4. Because the connection has already been closed, writing will fail with EPIPE which is detected

Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

Thanks for your explanation Fredrik! However, I believe your 4. step is not what happens in the current implementation as the write call in wrapper.c dies directly. I see three ways to fix the problem: (1) Make upload-pack wait for a response (with timeout) before it closes the pipe. However,

Re: [RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

Lars Schneider writes: > (1) Make upload-pack wait for a response (with timeout) before it > closes the pipe. However, I believe this would not be in line with > the general Git philosophy stated in "git.c" (added in 7559a1be): > "Many parts of Git have subprograms

[RFC] t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" flaky?

Hi, while working on the Git CI integration I noticed that t5516 "75 - deny fetch unreachable SHA1, allowtipsha1inwant=true" (introduced in 68ee628) seems to be flaky on TravisCI. I get the following output in verbose mode: