Re: [RFC 02/10] submodule: fix getting custom gitmodule file in fetch command

2018-04-16 Thread Antonio Ospite
On Mon, 16 Apr 2018 12:23:59 -0700 Stefan Beller wrote: > On Mon, Apr 16, 2018 at 9:18 AM, Antonio Ospite wrote: > > > > > Is there an API to just load one config setting? > > Do you mean to > > git -c key=value foo-command --options ... I meant, instead

Re: [RFC 02/10] submodule: fix getting custom gitmodule file in fetch command

2018-04-16 Thread Stefan Beller
On Mon, Apr 16, 2018 at 9:18 AM, Antonio Ospite wrote: > > Is there an API to just load one config setting? Do you mean to git -c key=value foo-command --options ...

Re: [RFC 02/10] submodule: fix getting custom gitmodule file in fetch command

2018-04-16 Thread Antonio Ospite
On Thu, 12 Apr 2018 16:55:15 -0700 Stefan Beller wrote: > Hi Antonio, > > the subject line could also be > fetch: fix custom submodule location > as I was not expecting this patch from the subject line. > OK. > On Thu, Apr 12, 2018 at 3:20 PM, Antonio Ospite

Re: [RFC 02/10] submodule: fix getting custom gitmodule file in fetch command

2018-04-12 Thread Stefan Beller
Hi Antonio, the subject line could also be fetch: fix custom submodule location as I was not expecting this patch from the subject line. On Thu, Apr 12, 2018 at 3:20 PM, Antonio Ospite wrote: > Import the default git configuration before accessing the gitmodules > file. > > This

[RFC 02/10] submodule: fix getting custom gitmodule file in fetch command

2018-04-12 Thread Antonio Ospite
Import the default git configuration before accessing the gitmodules file. This is important when a value different from the default one is set via the 'core.submodulesfile' config. Signed-off-by: Antonio Ospite --- builtin/fetch.c | 2 +- 1 file changed, 1 insertion(+), 1