On Thu, May 29, 2014 at 09:54:10PM -0700, Linus Torvalds wrote:
That said, part of it is just that show-signature is so suboptimal
performance-wise, re-parsing the commit buffer for each commit when
show_signature is set. That's just crazy, we've already parsed the
commit text, we already
Jeff King p...@peff.net writes:
On Thu, May 29, 2014 at 09:54:10PM -0700, Linus Torvalds wrote:
That said, part of it is just that show-signature is so suboptimal
performance-wise, re-parsing the commit buffer for each commit when
show_signature is set. That's just crazy, we've already
On Fri, May 30, 2014 at 09:55:14AM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
On Thu, May 29, 2014 at 09:54:10PM -0700, Linus Torvalds wrote:
That said, part of it is just that show-signature is so suboptimal
performance-wise, re-parsing the commit buffer for each
Jeff King p...@peff.net writes:
On Fri, May 30, 2014 at 09:55:14AM -0700, Junio C Hamano wrote:
I don't think we need to worry about commit-buffer being mucked with.
It is always either NULL, or points to the original object contents.
Encoded log messages are always placed in a separate
On Fri, May 30, 2014 at 10:35:14AM -0700, Junio C Hamano wrote:
Do you want me to roll it up with a real commit message?
Yes. I think the change is sensible.
Here it is. We may want to make these helper functions available to
other callers so they can use the same trick, but I do not know
On Fri, May 30, 2014 at 02:34:41PM -0400, Jeff King wrote:
On Fri, May 30, 2014 at 10:35:14AM -0700, Junio C Hamano wrote:
Do you want me to roll it up with a real commit message?
Yes. I think the change is sensible.
Here it is. [...]
By the way, I rather derailed Linus's original
Jeff King p...@peff.net writes:
Subject: [PATCH] reuse commit-buffer when parsing signatures
...
Signed-off-by: Jeff King p...@peff.net
Hmph, unfortunately this seems to break t7510.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to
On Fri, May 30, 2014 at 01:44:32PM -0700, Junio C Hamano wrote:
Jeff King p...@peff.net writes:
Subject: [PATCH] reuse commit-buffer when parsing signatures
...
Signed-off-by: Jeff King p...@peff.net
Hmph, unfortunately this seems to break t7510.
Urgh, sorry for not testing more
Junio C Hamano gits...@pobox.com writes:
Jeff King p...@peff.net writes:
Subject: [PATCH] reuse commit-buffer when parsing signatures
...
Signed-off-by: Jeff King p...@peff.net
Hmph, unfortunately this seems to break t7510.
And I think without re-reading the patch I know what is wrong.
Jeff King p...@peff.net writes:
I wonder if it would be sane to remove or quote NULs when attaching the
buffer to commit-buffer. That would _break_ signatures, but that is a
good thing. I do not think there is a reason to have NULs in your commit
message unless you are doing something
From: Linus Torvalds torva...@linux-foundation.org
Date: Thu, 29 May 2014 15:19:40 -0700
Subject: [RFC PATCH] git log: support auto decorations
This works kind of like --color=auto - add decorations for interactive
use, but do not change defaults when scripting or when piping the output
On Thu, May 29, 2014 at 03:31:58PM -0700, Linus Torvalds wrote:
From: Linus Torvalds torva...@linux-foundation.org
Date: Thu, 29 May 2014 15:19:40 -0700
Subject: [RFC PATCH] git log: support auto decorations
I will spare you the usual lecture on having these lines in the message
body. ;)
I
On Thu, May 29, 2014 at 6:58 PM, Jeff King p...@peff.net wrote:
I will spare you the usual lecture on having these lines in the message
body. ;)
We do it for the kernel because they often get lost otherwise.
Particularly the date/author.
git doesn't tend to have the same kind of deep email
13 matches
Mail list logo
