Re: [RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-30 Thread Phillip Wood
On 27/07/18 13:37, Johannes Schindelin wrote: > Hi Phillip, Junio and Akinori, > > I just noticed that t3404 is broken without my patches (but with Junio's > fixup), on Windows, macOS and Linux. (See log at the end.) > > On Fri, 27 Jul 2018, Phillip Wood wrote: > >> On 26/07/18 13:33, Johannes

Re: [RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-27 Thread Johannes Schindelin
Hi Phillip, Junio and Akinori, I just noticed that t3404 is broken without my patches (but with Junio's fixup), on Windows, macOS and Linux. (See log at the end.) On Fri, 27 Jul 2018, Phillip Wood wrote: > On 26/07/18 13:33, Johannes Schindelin wrote: > > > > On Wed, 18 Jul 2018, Phillip Wood

Re: [RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-27 Thread Phillip Wood
Hi Johannes On 26/07/18 13:33, Johannes Schindelin wrote: > Hi Phillip, > > On Wed, 18 Jul 2018, Phillip Wood wrote: > >> From: Phillip Wood >> >> Single quotes should be escaped as \' not \\'. Note that this only >> affects authors that contain a single quote and then only external >> scripts

Re: [RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-26 Thread Johannes Schindelin
Hi Phillip, On Wed, 18 Jul 2018, Phillip Wood wrote: > From: Phillip Wood > > Single quotes should be escaped as \' not \\'. Note that this only > affects authors that contain a single quote and then only external > scripts that read the author script and users whose git is upgraded from > the

Re: [RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-24 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Single quotes should be escaped as \' not \\'. Note that this only > affects authors that contain a single quote and then only external > scripts that read the author script and users whose git is upgraded from > the shell version of rebase -i while

[RFC PATCH] sequencer: fix quoting in write_author_script

2018-07-18 Thread Phillip Wood
From: Phillip Wood Single quotes should be escaped as \' not \\'. Note that this only affects authors that contain a single quote and then only external scripts that read the author script and users whose git is upgraded from the shell version of rebase -i while rebase was stopped. This is