Re: [RFC PATCH] transport: list refs before fetch if necessary

2018-09-25 Thread Junio C Hamano
Jonathan Tan writes: > diff --git a/transport-helper.c b/transport-helper.c > index 143ca008c8..7213fa0d32 100644 > --- a/transport-helper.c > +++ b/transport-helper.c > @@ -1105,6 +1105,7 @@ static struct ref *get_refs_list(struct transport > *transport, int for_push, > } > > static struct

[RFC PATCH] transport: list refs before fetch if necessary

2018-09-25 Thread Jonathan Tan
The built-in bundle transport and the transport helper interface do not work when transport_fetch_refs() is called immediately after transport creation. Evidence: fetch_refs_from_bundle() relies on data->header being initialized in get_refs_from_bundle(), and fetch() in transport-helper.c relies