[RFC PATCH 0/2] alternate hash test

2018-01-28 Thread brian m. carlson
This series wires up an alternate hash implementation, namely BLAKE2b-160. The goal is to allow us to identify tests which rely on the hash algorithm in use so that we can fix those tests. For this test, I picked BLAKE2b-160 for a couple reasons: * Debian ships a libb2-1 package which can be used

Re: [RFC PATCH 0/2] alternate hash test

2018-01-28 Thread SZEDER Gábor
> This series wires up an alternate hash implementation, namely > BLAKE2b-160. The goal is to allow us to identify tests which rely on > the hash algorithm in use so that we can fix those tests. > t9903-bash-prompt.sh (Wstat: 256 Tests: 66 > Failed: 53) > Failed tes

Re: [RFC PATCH 0/2] alternate hash test

2018-01-28 Thread Ævar Arnfjörð Bjarmason
On Sun, Jan 28, 2018 at 6:06 PM, brian m. carlson wrote: > For this test, I picked BLAKE2b-160 for a couple reasons: > * Debian ships a libb2-1 package which can be used easily (in other > words, I was lazy and didn't want to add a crypto implementation just > for test purposes); > [...] > Thi

Re: [RFC PATCH 0/2] alternate hash test

2018-01-28 Thread brian m. carlson
On Sun, Jan 28, 2018 at 07:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote: > On Sun, Jan 28, 2018 at 6:06 PM, brian m. carlson > wrote: > If the goal is to smoke out hardcoded SHA1s in tests, isn't it easier > to instrument SHA-1 (e.g. our blk_sha1 copy, or our wrappers) to > pretend that whenever w

Re: [RFC PATCH 0/2] alternate hash test

2018-01-30 Thread Junio C Hamano
"brian m. carlson" writes: > This series wires up an alternate hash implementation, namely > BLAKE2b-160. The goal is to allow us to identify tests which rely on > the hash algorithm in use so that we can fix those tests. Yay. > Provoking discussion of which hash to pick for NewHash is explici

Re: [RFC PATCH 0/2] alternate hash test

2018-01-30 Thread Stefan Beller
On Sun, Jan 28, 2018 at 9:06 AM, brian m. carlson wrote: > This series wires up an alternate hash implementation, namely > BLAKE2b-160. The goal is to allow us to identify tests which rely on > the hash algorithm in use so that we can fix those tests. > > For this test, I picked BLAKE2b-160 for a

Re: [RFC PATCH 0/2] alternate hash test

2018-01-31 Thread brian m. carlson
On Tue, Jan 30, 2018 at 05:04:52PM -0800, Stefan Beller wrote: > Thanks for writing this, I chose a slightly different approach at > https://public-inbox.org/git/20170728171817.21458-2-sbel...@google.com/ > which might be quicker for local testing. I'm actually going to rework the patches to be mu