Re: [RFC PATCH 0/3] rebase-interactive

{cc:+junio} On Tue, Mar 20, 2018 at 11:31 PM, Wink Saville wrote: > Anyway, I've played around and my current thoughts are to not create > any new files and keep git_rebase__interactive and the new > git_rebase__interactive__preserve_merges functions in >

Re: [RFC PATCH 0/3] rebase-interactive

On Tue, Mar 20, 2018 at 2:47 PM, Eric Sunshine wrote: > On Tue, Mar 20, 2018 at 5:23 PM, Wink Saville wrote: >> On Tue, Mar 20, 2018 at 2:11 PM, Eric Sunshine >> wrote: >>> A problem with this approach is that it loses "blame"

Re: [RFC PATCH 0/3] rebase-interactive

On Tue, Mar 20, 2018 at 5:23 PM, Wink Saville wrote: > On Tue, Mar 20, 2018 at 2:11 PM, Eric Sunshine > wrote: >> A problem with this approach is that it loses "blame" information. A >> git-blame of git-rebase--interactive--lib.sh shows all code in

Re: [RFC PATCH 0/3] rebase-interactive

On Tue, Mar 20, 2018 at 2:11 PM, Eric Sunshine wrote: > On Tue, Mar 20, 2018 at 4:45 PM, Wink Saville wrote: >> Patch 0001 creates a library of functions which can be >> used by git-rebase--interactive and >> git-rebase--interactive--preserve-merges.

Re: [RFC PATCH 0/3] rebase-interactive

On Tue, Mar 20, 2018 at 4:45 PM, Wink Saville wrote: > Patch 0001 creates a library of functions which can be > used by git-rebase--interactive and > git-rebase--interactive--preserve-merges. The functions are > those that exist in git-rebase--interactive.sh plus new > functions

[RFC PATCH 0/3] rebase-interactive

I've not worked on the git sources before and while looking into fixing test_expect_failure 'exchange two commits with -p' in t3404-rebase-interactive.sh, I found it difficult to understand the git testing infracture and git-rebase--interactive.sh. So as part of learning my way around I thought